[webkit-reviews] review granted: [Bug 229278] Replace the uint64_t used to identify taps with an ObjectIdentifier<> type : [Attachment 435837] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 229278: Replace the uint64_t used to identify taps with an
ObjectIdentifier<> type
https://bugs.webkit.org/show_bug.cgi?id=229278

Attachment 435837: Patch

https://bugs.webkit.org/attachment.cgi?id=435837&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 435837
  --> https://bugs.webkit.org/attachment.cgi?id=435837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435837&action=review

r=me once this is rebased on trunk

> Source/WebKit/Shared/IdentifierTypes.h:34
> +

Nice. This seems like a good place to put the various other identifier types
used in WebKit2 that are currently just in their own headers, but we can do
that later.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3113
> +

Nit - stray newline here.