[webkit-reviews] review granted: [Bug 229253] Add a new option '--show-window' to run-webkit-tests : [Attachment 435805] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 229253: Add a new option '--show-window' to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=229253

Attachment 435805: Patch

https://bugs.webkit.org/attachment.cgi?id=435805&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 435805
  --> https://bugs.webkit.org/attachment.cgi?id=435805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435805&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:343
> +	   optparse.make_option('--show-window', action="store_true",
default=False, help="If set, a window (with webview) will show up. Helpful for
debugging some tests."),

I think the help should say "Make the test runner window visible during
testing"