[webkit-reviews] review granted: [Bug 228984] PCM: Support ephemeral measurement with non-persistent WebCore::PrivateClickMeasurement : [Attachment 435456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 13:27:35 PDT 2021

Kate Cheney <katherine_cheney at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 228984: PCM: Support ephemeral measurement with non-persistent

Attachment 435456: Patch


--- Comment #6 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 435456
  --> https://bugs.webkit.org/attachment.cgi?id=435456

View in context: https://bugs.webkit.org/attachment.cgi?id=435456&action=review

Needs to be rebased to fix some data races but otherwise LGTM.

> Source/WebCore/loader/PrivateClickMeasurement.h:50
> +enum class PrivateClickMeasurementAttributionPersistent : bool { Yes, No };

I think we usually use { No, Yes }.

> Source/WebCore/loader/PrivateClickMeasurement.h:392
> +    PrivateClickMeasurementAttributionPersistent m_isPersistent;

You may need to set the default value to be ::Yes, I think enums default to 0
which will be ::No if you change the ordering above.

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:248
> +	   m_ephemeralMeasurement = measurement;

m_ephemeralMeasurement = WTFMove(measurement) I think.

More information about the webkit-reviews mailing list