[webkit-reviews] review granted: [Bug 229236] Do not terminate relaunched network process when getting network process connection : [Attachment 435774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 09:53:15 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 229236: Do not terminate relaunched network process when getting network
process connection
https://bugs.webkit.org/show_bug.cgi?id=229236

Attachment 435774: Patch

https://bugs.webkit.org/attachment.cgi?id=435774&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 435774
  --> https://bugs.webkit.org/attachment.cgi?id=435774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435774&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1762
> +		       if (networkProcessProxy && networkProcessProxy.get() ==
strongThis->m_networkProcess.get())

Do we really need the ".get()" on either side? It should be OK to == RefPtrs.


More information about the webkit-reviews mailing list