[webkit-reviews] review granted: [Bug 228893] [GTK] WTFCrash in WebCore::FontCache::lastResortFallbackFont : [Attachment 435757] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 18 09:20:57 PDT 2021


Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 228893: [GTK] WTFCrash in WebCore::FontCache::lastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=228893

Attachment 435757: Patch

https://bugs.webkit.org/attachment.cgi?id=435757&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 435757
  --> https://bugs.webkit.org/attachment.cgi?id=435757
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435757&action=review

> Source/WebCore/rendering/style/RenderStyleConstants.h:1111
> +static const float maximumAllowedFontSize = 65535.0f;

How about: std::numeric_limits<unsigned short>::max?


More information about the webkit-reviews mailing list