[webkit-reviews] review requested: [Bug 228302] macOS key-driven smooth scrolling does not stop when focus changes : [Attachment 435745] Manual testing works, LayoutTest still broken

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 228302: macOS key-driven smooth scrolling does not stop when focus changes
https://bugs.webkit.org/show_bug.cgi?id=228302

Attachment 435745: Manual testing works, LayoutTest still broken

https://bugs.webkit.org/attachment.cgi?id=435745&action=review




--- Comment #7 from Beth Dakin <bdakin at apple.com> ---
Created attachment 435745

  --> https://bugs.webkit.org/attachment.cgi?id=435745&action=review

Manual testing works, LayoutTest still broken

I still haven't dug into the testing code Dana wrote, and the test is still
failing locally for me. Posting to get any feedback on the WebCore changes (and
just to keep track of the WebCore changes in case I don't get to fixing the
test very soon, in case someone else picks this up).

Manually testing, I see the following behaviors, which all match shipping:

- If you are keyboard scrolling the main frame and switch focus to a different
browser window while still holding the arrow key, scrolling in the now inactive
window animates to a stop right away, while still holding the key.

- If you are keyboard scrolling the main frame and switch focus to a different
app while still holding the arrow key, scrolling in the now inactive window
stops when you release the key (but continues until then).

- If you are keyboard scrolling a subframe and switch focus to another subframe
or the mainframe, scrolling in the now blurred frame animates to a stop, and
the focused frames starts scrolling while the key is still held down.