[webkit-reviews] review granted: [Bug 224415] position: sticky with display: inline-block : [Attachment 435673] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 224415: position: sticky with display: inline-block
https://bugs.webkit.org/show_bug.cgi?id=224415

Attachment 435673: Patch

https://bugs.webkit.org/attachment.cgi?id=435673&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 435673
  --> https://bugs.webkit.org/attachment.cgi?id=435673
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435673&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:461
> +    if (this->isInline() && containingBlock->isAnonymousBlock())
> +	   containingBlock = containingBlock->containingBlock();

I think it's possible to have multiple containing anonymous blocks so this
should do something like nearestNonAnonymousContainingBlockIncludingSelf().