[webkit-reviews] review granted: [Bug 229213] Describe the HTTPS servers in run-webkit-httpd output : [Attachment 435722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 17 16:57:25 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 229213: Describe the HTTPS servers in run-webkit-httpd output
https://bugs.webkit.org/show_bug.cgi?id=229213

Attachment 435722: Patch

https://bugs.webkit.org/attachment.cgi?id=435722&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 435722
  --> https://bugs.webkit.org/attachment.cgi?id=435722
Patch

Nice improvement, although that's still not an exhaustive list AFAICT.

Also, can't help but notice this fixme between patch chunks that was invisible
when I opened this page:

# FIXME(154294): somehow retrieve the actual ports and interfaces bound by the
httpd server


More information about the webkit-reviews mailing list