[webkit-reviews] review granted: [Bug 229110] [WebXR] A session with only one view should cover the full screen : [Attachment 435714] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 229110: [WebXR] A session with only one view should cover the full screen
https://bugs.webkit.org/show_bug.cgi?id=229110

Attachment 435714: Patch

https://bugs.webkit.org/attachment.cgi?id=435714&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 435714
  --> https://bugs.webkit.org/attachment.cgi?id=435714
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435714&action=review

> Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:327
> +    if (m_session->mode() == XRSessionMode::ImmersiveVr &&
m_session->views().size() > 1) {

Odd that "number of views is > 1" then goes around and assumes it's 2. I guess
we won't need WebXR for spiders any time soon.

> LayoutTests/http/wpt/webxr/resources/webxr_test_constants_single_view.js:150
> +  supportsImmersive: true,

This file is fairly chaotic indentationwise (as are the others)