[webkit-reviews] review granted: [Bug 229172] [webkitcorepy] Return SourceFileLoader in find_module : [Attachment 435650] Patch

[bugzilla-daemon at webkit.org]

Stephanie Lewis <slewis at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 229172: [webkitcorepy] Return SourceFileLoader in find_module
https://bugs.webkit.org/show_bug.cgi?id=229172

Attachment 435650: Patch

https://bugs.webkit.org/attachment.cgi?id=435650&action=review




--- Comment #5 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 435650
  --> https://bugs.webkit.org/attachment.cgi?id=435650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435650&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:603
> +	       # Python 2 works find with the default module finder, once we've
installed the module in question

typo fine

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:609
> +	       for trail in ('', '.py', '.pyc', '.py3', '.pyo'):

would ext be a better name than trail?

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:614
> +	       if not os.path.isdir(part):

do you mean path here?