[webkit-reviews] review granted: [Bug 229145] [GStreamer][EME] Try to parse XML init datas that could possibly come from MPD manifests : [Attachment 435610] Patch

[bugzilla-daemon at webkit.org]

Alicia Boya García <aboya at igalia.com> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 229145: [GStreamer][EME] Try to parse XML init datas that could possibly
come from MPD manifests
https://bugs.webkit.org/show_bug.cgi?id=229145

Attachment 435610: Patch

https://bugs.webkit.org/attachment.cgi?id=435610&action=review




--- Comment #3 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 435610
  --> https://bugs.webkit.org/attachment.cgi?id=435610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435610&action=review

LGTM.

>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:81
>> +	if (g_markup_parse_context_parse(markupParseContext.get(),
payload->dataAsCharPtr(), payload->size(), &error.outPtr()) && userData.pssh)
> 
> g_warning() mentioning the error message if this fails?

It is expected to fail in the case it's not an XML, right? I would emit a
warning when an XML is found but no pssh was parsed though.