[webkit-reviews] review granted: [Bug 229133] Add support for RTCDtlsTransport : [Attachment 435594] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 229133: Add support for RTCDtlsTransport
https://bugs.webkit.org/show_bug.cgi?id=229133

Attachment 435594: Patch

https://bugs.webkit.org/attachment.cgi?id=435594&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 435594
  --> https://bugs.webkit.org/attachment.cgi?id=435594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435594&action=review

> Source/WebCore/Modules/mediastream/RTCDtlsTransport.cpp:3
> + * Copyright (C) 2017 Apple Inc. All rights reserved.

s/2017/2021/

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp:
2
> + * Copyright (C) 2018 Apple Inc.

Ditto.

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h:2
> + * Copyright (C) 2018 Apple Inc.

Ditto

>
LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceConnect
ionState.https-expected.txt:11
> +FAIL iceConnectionState changes at the right time, with bundle policy
balanced promise_test: Unhandled rejection with value: object "TypeError:
undefined is not an object (evaluating 'transport.state')"
> +FAIL iceConnectionState changes at the right time, with bundle policy
max-bundle promise_test: Unhandled rejection with value: object "TypeError:
undefined is not an object (evaluating 'transport.state')"
> +FAIL iceConnectionState changes at the right time, with bundle policy
max-compat promise_test: Unhandled rejection with value: object "TypeError:
undefined is not an object (evaluating 'transport.state')"

Do we need a bug for these and the other new/changed test failures?