[webkit-reviews] review granted: [Bug 220213] [LFC Display] Give display boxes a previousSibling pointer : [Attachment 435554] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 220213: [LFC Display] Give display boxes a previousSibling pointer
https://bugs.webkit.org/show_bug.cgi?id=220213

Attachment 435554: Patch

https://bugs.webkit.org/attachment.cgi?id=435554&action=review




--- Comment #5 from zalan <zalan at apple.com> ---
Comment on attachment 435554
  --> https://bugs.webkit.org/attachment.cgi?id=435554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435554&action=review

> Source/WebCore/ChangeLog:10
> +	   Hit-testing will need to iterate Display::Box siblings in reverse
order, so add
> +	   a pointer to the previous sibling box, and assign it during tree
building. Also
> +	   add a lastChild pointer to Display::ContainerBox.

In integration we just iterate the vector backwards.
nvm, it looks like DisplayBox objects are already forming a tree.

> Source/WebCore/display/css/DisplayBox.h:101
> +    Box* m_previousSibling { nullptr };

WeakPtr?

> Source/WebCore/display/css/DisplayContainerBox.h:51
> +    Box* m_lastChild { nullptr };

WeakPtr?