[webkit-reviews] review granted: [Bug 229041] Add Cross-Origin-Embedder-Policy support for Blob URLs : [Attachment 435521] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 229041: Add Cross-Origin-Embedder-Policy support for Blob URLs
https://bugs.webkit.org/show_bug.cgi?id=229041

Attachment 435521: Patch

https://bugs.webkit.org/attachment.cgi?id=435521&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 435521
  --> https://bugs.webkit.org/attachment.cgi?id=435521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435521&action=review

> Source/WebKitLegacy/win/WebCoreSupport/WebPlatformStrategies.cpp:84
> +    void registerBlobURL(const URL& url, const URL& srcURL, const
CrossOriginOpenerPolicy& coop, const CrossOriginEmbedderPolicy& coep) final {
m_blobRegistry.registerBlobURL(url, srcURL, coop, coep); }

Should we make a struct that contains both and call it CrossOriginPolicies?

> LayoutTests/platform/mac-wk1/TestExpectations:376
>
+imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popu
p.https.html [ Skip ]

Why not skip the whole directory?

> LayoutTests/platform/win/TestExpectations:3728
>
+imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popu
p.https.html [ Skip ]

ditto