[webkit-reviews] review granted: [Bug 229093] Top layer: handle display: contents and non out-of-flow position values : [Attachment 435506] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 229093: Top layer: handle display: contents and non out-of-flow position
values
https://bugs.webkit.org/show_bug.cgi?id=229093

Attachment 435506: Patch

https://bugs.webkit.org/attachment.cgi?id=435506&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 435506
  --> https://bugs.webkit.org/attachment.cgi?id=435506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435506&action=review

> Source/WebCore/style/StyleAdjuster.cpp:583
> +    if (!m_element && style.styleType() != PseudoId::Before &&
style.styleType() != PseudoId::After) {

Would be nice to wrap the PseudoId::Before & PseudoId::After check in a
function that is named using a spec-related term; maybe put it as a static
function in some pseudo-related code.