[webkit-reviews] review denied: [Bug 229080] Build ANGLE as intermediate static library : [Attachment 435495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 13 12:39:08 PDT 2021

Alex Christensen <achristensen at apple.com> has denied Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 229080: Build ANGLE as intermediate static library

Attachment 435495: Patch


--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 435495
  --> https://bugs.webkit.org/attachment.cgi?id=435495

View in context: https://bugs.webkit.org/attachment.cgi?id=435495&action=review

This effectively undoes r276734 which was done for a good reason.  I've also
been dealing with and fixing internal fallout from that change for several
months since then.   I very very strongly oppose doing this right now, and only
one very strongly oppose doing this in the future.  The stated reason has
something to do with unit testing ANGLE.  Is there no other way to do that? 
Can we not make the dylib able to be used in unit tests instead?  That would
have the added benefit of testing a closer configuration to what customers see.

> Source/ThirdParty/ANGLE/ChangeLog:21
> +	   Remove stale scheme that was left when this work was originally
removed in
> +	   bug 225162.

This sounds like a good thing to do.

More information about the webkit-reviews mailing list