[webkit-reviews] review granted: [Bug 229072] [MSE][GStreamer] Implement multi-track support : [Attachment 435480] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 229072: [MSE][GStreamer] Implement multi-track support
https://bugs.webkit.org/show_bug.cgi?id=229072

Attachment 435480: Patch

https://bugs.webkit.org/attachment.cgi?id=435480&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 435480
  --> https://bugs.webkit.org/attachment.cgi?id=435480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435480&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:366
> +		   m_done = true;

TRUE

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:293
> +void AppendPipeline::parseDemuxerSrcPadCaps(GstCaps* demuxerSrcPadCaps,
GRefPtr<GstCaps>* dstParsedCaps,
> +    StreamType* dstStreamType, FloatSize* dstPresentationSize)

if dst* parameters are output parameters, please return a tuple.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:634
> +AppendPipeline::Track* AppendPipeline::tryCreateTrackFromPad(GstPad*
demuxerSrcPad, bool* dstAppendParsingFailed, int trackIndex)

Please return an optional and avoid the failed bool