[webkit-reviews] review granted: [Bug 229067] [WPE] WebExtension API test /webkit/WebKitWebView/web-process-crashed is flaky failing : [Attachment 435478] Patch with updated expectations
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 13 07:20:48 PDT 2021
Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 229067: [WPE] WebExtension API test
/webkit/WebKitWebView/web-process-crashed is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=229067
Attachment 435478: Patch with updated expectations
https://bugs.webkit.org/attachment.cgi?id=435478&action=review
--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 435478
--> https://bugs.webkit.org/attachment.cgi?id=435478
Patch with updated expectations
View in context: https://bugs.webkit.org/attachment.cgi?id=435478&action=review
> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:166
> + Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
> g_main_loop_run(test->m_mainLoop);
> + Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);
Ok, I think we should still check if we can remove the g_warning in wpe-fdo,
because thi might hide other warnings happening.
More information about the webkit-reviews
mailing list