[webkit-reviews] review granted: [Bug 228227] [GTK][WPE] Add API to pass WebKitMemoryPressureHandler parameters to the network processes : [Attachment 434081] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 228227: [GTK][WPE] Add API to pass WebKitMemoryPressureHandler parameters
to the network processes
https://bugs.webkit.org/show_bug.cgi?id=228227

Attachment 434081: Patch

https://bugs.webkit.org/attachment.cgi?id=434081&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 434081
  --> https://bugs.webkit.org/attachment.cgi?id=434081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434081&action=review

> Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:42
> +    static const char* disableMemoryPressureMonitor =
getenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR");

Since this is static, you should check if we already have a value before
getting it again.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:823
> +	   WebKitMemoryPressureSettings* settings =
webkit_memory_pressure_settings_new();
> +	   webkit_website_data_manager_set_memory_pressure_settings(settings);
> +	   webkit_memory_pressure_settings_free(settings);

Since the config is std::optional, I think we can allow to pass NULL and pass
std::optional to the process pool