[webkit-reviews] review granted: [Bug 229068] nexttrack and previoustrack MediaSession handlers not working : [Attachment 435471] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 13 00:07:39 PDT 2021


youenn fablet <youennf at gmail.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 229068: nexttrack and previoustrack MediaSession handlers not working
https://bugs.webkit.org/show_bug.cgi?id=229068

Attachment 435471: Patch

https://bugs.webkit.org/attachment.cgi?id=435471&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 435471
  --> https://bugs.webkit.org/attachment.cgi?id=435471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435471&action=review

> Source/WebCore/ChangeLog:12
> +	   used with the MediaRemote backend, which prevents automating the
test.

Could we do the following:
- Use MediaSession API to trigger adding handlers for nexttrack.
- Add an Internals.idl API to get the supported commands, which would generate
a string. Validate 'nexttrack' is in the commands?

Another approach would be to add a mock backend, which sounds feasible as well.


More information about the webkit-reviews mailing list