[webkit-reviews] review requested: [Bug 229019] [JSC] Enable ThinLTO : [Attachment 435393] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has asked  for review:
Bug 229019: [JSC] Enable ThinLTO
https://bugs.webkit.org/show_bug.cgi?id=229019

Attachment 435393: Patch

https://bugs.webkit.org/attachment.cgi?id=435393&action=review




--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 435393
  --> https://bugs.webkit.org/attachment.cgi?id=435393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435393&action=review

>>> Source/JavaScriptCore/ChangeLog:3
>>> +	     [JSC] Enable ThinLTO
>> 
>> What is the build time impact? What I’m observing for the rest of WebKit is
substantially slower than what was promised when we were enabling it, and we
should consider disabling it everywhere :(
>> 
>> If this adds minutes to build time, it’s likely not worth 0.3%.
> 
> No, we are really needing to have any sub-percent currently. 0.3% is *huge*.

Turned out this only adds ~1 min to builder.