[webkit-reviews] review canceled: [Bug 228285] [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are flaky failing : [Attachment 435438] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 228285: [ iOS Debug] 3 editing/pasteboard/smart-paste-paragraph tests are
flaky failing
https://bugs.webkit.org/show_bug.cgi?id=228285

Attachment 435438: Patch

https://bugs.webkit.org/attachment.cgi?id=435438&action=review




--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 435438
  --> https://bugs.webkit.org/attachment.cgi?id=435438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435438&action=review

>> Tools/WebKitTestRunner/ios/TestControllerIOS.mm:171
>> +	if (![preferencesActions
oneTimeActionCompleted:@"HardwareKeyboardLastSeen"])
> 
> Nit: "HardwareKeyboardLastSeen" could be stored in a variable, similar to the
other keys in this method.

Make sense!