[webkit-reviews] review requested: [Bug 229044] Migrate Performance::resourceTimingBufferFullTimerFired to HTML event loop : [Attachment 435436] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 229044: Migrate Performance::resourceTimingBufferFullTimerFired to HTML
event loop
https://bugs.webkit.org/show_bug.cgi?id=229044

Attachment 435436: Patch

https://bugs.webkit.org/attachment.cgi?id=435436&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 435436
  --> https://bugs.webkit.org/attachment.cgi?id=435436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435436&action=review

> Source/WebCore/page/Performance.cpp:281
>      ASSERT(scriptExecutionContext());

I don't think this assertion holds anymore. You probably want to switch that to
an early return. The HTML event loop can fire tasks after the script execution
context is gone.