[webkit-reviews] review granted: [Bug 227801] Implement ::backdrop pseudo element : [Attachment 435420] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 227801: Implement ::backdrop pseudo element
https://bugs.webkit.org/show_bug.cgi?id=227801

Attachment 435420: Patch

https://bugs.webkit.org/attachment.cgi?id=435420&action=review




--- Comment #13 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 435420
  --> https://bugs.webkit.org/attachment.cgi?id=435420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435420&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:189
> +    WeakPtr backdropRenderer = renderer.backdropRenderer();

could be auto

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:201
> +    WeakPtr currentParent = makeWeakPtr(backdropRenderer->parent());
> +    WeakPtr newParent = makeWeakPtr(renderer.parent());

these too