[webkit-reviews] review granted: [Bug 229032] [GTK] Simplify TestWebKitAccessibility : [Attachment 435414] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 229032: [GTK] Simplify TestWebKitAccessibility
https://bugs.webkit.org/show_bug.cgi?id=229032

Attachment 435414: Patch

https://bugs.webkit.org/attachment.cgi?id=435414&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 435414
  --> https://bugs.webkit.org/attachment.cgi?id=435414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435414&action=review

Heh, nice!

> Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:41
> +	   // We can get warnings from atspi when trying to connect to
applications.
> +	   Test::removeLogFatalFlag(G_LOG_LEVEL_WARNING);
>	   int childCount = atspi_accessible_get_child_count(desktop.get(),
nullptr);
> +	   Test::addLogFatalFlag(G_LOG_LEVEL_WARNING);

What sort of warnings?

Certainly not failing the test is good to do, but they probably pollute the
test log, don't they?