[webkit-reviews] review denied: [Bug 229014] ThreadSanitizer: data race in WebCore::CARingBufferStorageVector::setCurrentFrameBounds() / getCurrentFrameBounds() : [Attachment 435385] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 16:50:00 PDT 2021


Jer Noble <jer.noble at apple.com> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 229014: ThreadSanitizer: data race in
WebCore::CARingBufferStorageVector::setCurrentFrameBounds() /
getCurrentFrameBounds()
https://bugs.webkit.org/show_bug.cgi?id=229014

Attachment 435385: Patch v2

https://bugs.webkit.org/attachment.cgi?id=435385&action=review




--- Comment #10 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 435385
  --> https://bugs.webkit.org/attachment.cgi?id=435385
Patch v2

The entire point of the CARingBuffer is for it to be lockless; adding a lock to
address this race would be very bad for high-priority audio thread performance.
We should find another way to address this race.


More information about the webkit-reviews mailing list