[webkit-reviews] review granted: [Bug 228754] Add initial support for Cross-Origin-Embedder-Policy (COEP) : [Attachment 435380] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 16:13:40 PDT 2021


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 228754: Add initial support for Cross-Origin-Embedder-Policy (COEP)
https://bugs.webkit.org/show_bug.cgi?id=228754

Attachment 435380: Patch

https://bugs.webkit.org/attachment.cgi?id=435380&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 435380
  --> https://bugs.webkit.org/attachment.cgi?id=435380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435380&action=review

> Source/WebCore/loader/CrossOriginEmbedderPolicy.h:99
> +template<> struct EnumTraits<WebCore::CrossOriginEmbedderPolicyValue> {

This is unnecessary because it uses bool as its storage, and the decoders
already know that there are only 2 valid values


More information about the webkit-reviews mailing list