[webkit-reviews] review granted: [Bug 228821] webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html fails on Cocoa : [Attachment 435339] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 228821:
webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html fails on
Cocoa
https://bugs.webkit.org/show_bug.cgi?id=228821

Attachment 435339: Patch

https://bugs.webkit.org/attachment.cgi?id=435339&action=review




--- Comment #10 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 435339
  --> https://bugs.webkit.org/attachment.cgi?id=435339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435339&action=review

Looks good and pleasingly small! r+

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-5780
> -    // FIXME: Turn this into a GPU-GPU texture copy instead of CPU readback.

Is this FIXME still relevant (to ImageBuffer::copyImage), or was the
paintCurrentFrameInContext call the CPU readback? I don't remember.