[webkit-reviews] review granted: [Bug 228987] ANGLE Cocoa compiles contents of ContextEAGL on mac : [Attachment 435330] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 12:30:13 PDT 2021


Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 228987: ANGLE Cocoa compiles contents of ContextEAGL on mac
https://bugs.webkit.org/show_bug.cgi?id=228987

Attachment 435330: Patch

https://bugs.webkit.org/attachment.cgi?id=435330&action=review




--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 435330
  --> https://bugs.webkit.org/attachment.cgi?id=435330
Patch

Looks good to me. We need to be sure to either upstream this or avoid losing it
while rolling ANGLE back down into WebKit. Do you want to point to this on
https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ?

r+


More information about the webkit-reviews mailing list