[webkit-reviews] review granted: [Bug 228986] ANGLE Cocoa compiles parts of HLSL translator, vulkan translator, libgl api, capture redundantly : [Attachment 435329] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 228986: ANGLE Cocoa compiles parts of HLSL translator, vulkan translator,
libgl api, capture redundantly
https://bugs.webkit.org/show_bug.cgi?id=228986

Attachment 435329: Patch

https://bugs.webkit.org/attachment.cgi?id=435329&action=review




--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 435329
  --> https://bugs.webkit.org/attachment.cgi?id=435329
Patch

Looks good to me if everything still builds and runs. While initially
integrating ANGLE into WebKit I had difficulty compiling out some of these
sources because doing so would have required code changes, so good to see you
made it work. r+