[webkit-reviews] review granted: [Bug 228947] Implement SFrameTransform error handling : [Attachment 435262] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 11 10:11:45 PDT 2021

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 228947: Implement SFrameTransform error handling

Attachment 435262: Patch


--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 435262
  --> https://bugs.webkit.org/attachment.cgi?id=435262

View in context: https://bugs.webkit.org/attachment.cgi?id=435262&action=review

> Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:118
> +static std::optional<Vector<uint8_t>> processFrame(const uint8_t* data,
size_t size, RTCRtpSFrameTransformer& transformer,
ScriptExecutionContextIdentifier identifier, const
WeakPtr<RTCRtpSFrameTransform>& weakTransform)

It might be worth using Span here and the other places you pass around {
uint8_t*, size_t } in these classes.

More information about the webkit-reviews mailing list