[webkit-reviews] review granted: [Bug 228978] Avoid infinite recursion when command buffer creation fails : [Attachment 435309] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 228978: Avoid infinite recursion when command buffer creation fails
https://bugs.webkit.org/show_bug.cgi?id=228978

Attachment 435309: Patch

https://bugs.webkit.org/attachment.cgi?id=435309&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 435309
  --> https://bugs.webkit.org/attachment.cgi?id=435309
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435309&action=review

Looks good; r+. Minor comment about the ChangeLog.

If there are any cases where this was found in the wild, I'd appreciate it if
you could mention them on https://bugs.webkit.org/show_bug.cgi?id=228978 .

> Source/ThirdParty/ANGLE/ChangeLog:9
> +	   In cases where the MTLCommandBuffer is not a valid metal object, we
can end up in an infinite recursive loop during context steup. Refactor
setupDraw to take no more than two attempts through the setup function. 

Could you reflow to 80 columns? This makes it easier to read the ChangeLogs and
commit messages later. Also: steup -> setup.