[webkit-reviews] review granted: [Bug 228965] Meta HTTP refresh should not navigate if document has sandboxed automatic features browsing context flag set : [Attachment 435281] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228965: Meta HTTP refresh should not navigate if document has sandboxed
automatic features browsing context flag set
https://bugs.webkit.org/show_bug.cgi?id=228965

Attachment 435281: Patch

https://bugs.webkit.org/attachment.cgi?id=435281&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 435281
  --> https://bugs.webkit.org/attachment.cgi?id=435281
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435281&action=review

> Source/WebCore/loader/NavigationScheduler.cpp:186
> +	       if (auto* document = frame.document()) {
> +		   if (document->isSandboxed(SandboxAutomaticFeatures)) {

Rather than nesting, I like this style:

    if (auto document = frame.document(); document &&
document->isSandboxed(SandboxAutomaticFeatures) {