[webkit-reviews] review granted: [Bug 228662] [git-webkit] Color `log` output : [Attachment 434915] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 228662: [git-webkit] Color `log` output
https://bugs.webkit.org/show_bug.cgi?id=228662

Attachment 434915: Patch

https://bugs.webkit.org/attachment.cgi?id=434915&action=review




--- Comment #5 from dewei_zhu at apple.com ---
Comment on attachment 434915
  --> https://bugs.webkit.org/attachment.cgi?id=434915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434915&action=review

r=me

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:73
> +	   if not isinstance(target, io.IOBase) and not isinstance(target,
file) and not isinstance(target, StringIO):

This can be simplified as `if not isinstance(target, [io.IOBase, file,
StringIO]):`

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:94
> +	   if not isinstance(target, io.IOBase) and not isinstance(target,
file) and not isinstance(target, StringIO):

ditto