[webkit-reviews] review denied: [Bug 228944] [Monterey] WebContent process immediately crash when GPU Process is disabled : [Attachment 435243] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 228944: [Monterey] WebContent process immediately crash when GPU Process is
disabled
https://bugs.webkit.org/show_bug.cgi?id=228944

Attachment 435243: Patch

https://bugs.webkit.org/attachment.cgi?id=435243&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 435243
  --> https://bugs.webkit.org/attachment.cgi?id=435243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435243&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1453
> +	       (require-not (extension "com.apple.webkit.extension.mach"))

This says that if we did not extend access to SYS_getpriority dynamically,
allow the syscall. Since we don't currently extend any syscalls dynamically I
think this will always be true.

Consequently, I would just add this to the existing "(when (defined?
'syscall-unix)" case inside a version check like we do for SYS_setattrlist.

Please also add the radar and a comment that we should remove it once the GPU
Process is permanently enabled.