[webkit-reviews] review granted: [Bug 228929] Don't instantiate a SYNotesActivationObserver to just say that it's not active or visible. : [Attachment 435219] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 228929: Don't instantiate a SYNotesActivationObserver to just say that it's
not active or visible.
https://bugs.webkit.org/show_bug.cgi?id=228929

Attachment 435219: Patch

https://bugs.webkit.org/attachment.cgi?id=435219&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 435219
  --> https://bugs.webkit.org/attachment.cgi?id=435219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435219&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:602
>      if (!m_appHighlightsObserver)
> -	   setUpHighlightsObserver();
> +	   return false;

Nit - I think you can just remove this early return altogether.