[webkit-reviews] review granted: [Bug 228890] [ARM64] Clean up and fix Pre/Post-Indexed Address Mode to Air for ARM64 (Load Instruction) : [Attachment 435168] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 228890: [ARM64] Clean up and fix Pre/Post-Indexed Address Mode to Air for
ARM64 (Load Instruction)
https://bugs.webkit.org/show_bug.cgi?id=228890

Attachment 435168: Patch

https://bugs.webkit.org/attachment.cgi?id=435168&action=review




--- Comment #13 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 435168
  --> https://bugs.webkit.org/attachment.cgi?id=435168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435168&action=review

r=me with nit.

> Source/JavaScriptCore/b3/B3CanonicalizePrePostIncrements.cpp:147
> +    auto detect = [&] (const HashMap<MemoryValue*, Value*>& candidates, bool
isPreIndexCandidates) {

Nit: I'd change `isPreIndexCandidate` to a lambda which contains the logic to
do the canonicalization. I find it to be an anti pattern to pass a bool to a
lambda where there is exactly one call with true and false.