[webkit-reviews] review granted: [Bug 228923] Blob URL changes after loading it : [Attachment 435210] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228923: Blob URL changes after loading it
https://bugs.webkit.org/show_bug.cgi?id=228923

Attachment 435210: Patch

https://bugs.webkit.org/attachment.cgi?id=435210&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 435210
  --> https://bugs.webkit.org/attachment.cgi?id=435210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435210&action=review

r=me

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:175
> +    if (isMainThread()) {
> +	   blobRegistry().registerBlobURLHandle(url);
> +	   return;
> +    }
> +    callOnMainThread([url = url.isolatedCopy()] {
> +	   blobRegistry().registerBlobURLHandle(url);
> +    });

Can we use ensureOnMainThread here?

> Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:186
> +    if (isMainThread()) {
> +	   blobRegistry().unregisterBlobURLHandle(url);
> +	   return;
> +    }
> +    callOnMainThread([url = url.isolatedCopy()] {
> +	   blobRegistry().unregisterBlobURLHandle(url);
> +    });

Ditto