[webkit-reviews] review granted: [Bug 228156] macOS key-driven smooth scrolling does not work for pageUp/pageDown : [Attachment 435197] Patch

Mon Aug 9 12:29:43 PDT 2021

Tim Horton <thorton at apple.com> has granted Dana Estra <destra at apple.com>'s
request for review:
Bug 228156: macOS key-driven smooth scrolling does not work for pageUp/pageDown
https://bugs.webkit.org/show_bug.cgi?id=228156

Attachment 435197: Patch

https://bugs.webkit.org/attachment.cgi?id=435197&action=review

--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 435197
  --> https://bugs.webkit.org/attachment.cgi?id=435197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435197&action=review

> LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:1
> +<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true
EventHandlerDrivenSmoothKeyboardScrollingEnabled=true ] -->

Should wait and see if these actually pass on iOS (on the bots). I am hopeful
but not certain :)

> LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:38
> +		   dist: 0

WebKit style generally prefers not abbreviating things (I guess this is
`distance`?)

> LayoutTests/fast/scrolling/keyboard-scrolling-distance-pageDown.html:42
> +		   checkSuccessfulScroll(scrollObj)

missing semicolon (not required, just a good habit)