[webkit-reviews] review granted: [Bug 228768] Support WTF logging channels : [Attachment 435163] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 8 20:37:25 PDT 2021
Fujii Hironori <Hironori.Fujii at sony.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228768: Support WTF logging channels
https://bugs.webkit.org/show_bug.cgi?id=228768
Attachment 435163: Patch
https://bugs.webkit.org/attachment.cgi?id=435163&action=review
--- Comment #14 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 435163
--> https://bugs.webkit.org/attachment.cgi?id=435163
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=435163&action=review
LGTM
> Source/WTF/wtf/unix/LoggingUnix.cpp:41
> + // To disable logging notImplemented set the DISABLE_NI_WARNING
environment variable to 1.
Remove this comment.
More information about the webkit-reviews
mailing list