[webkit-reviews] review granted: [Bug 228886] Clarify some identifier naming in RemoteRenderingBackend : [Attachment 435111] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 20:13:52 PDT 2021


Said Abou-Hallawa <sabouhallawa at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 228886: Clarify some identifier naming in RemoteRenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=228886

Attachment 435111: Patch

https://bugs.webkit.org/attachment.cgi?id=435111&action=review




--- Comment #2 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 435111
  --> https://bugs.webkit.org/attachment.cgi?id=435111
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435111&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:341
> +    // FIXME: All the callers pass m_pendingWakeupInfo.arguments so the body
of this function should just be this loop.

I am not sure I understand this comment. How should this function look in the
future?


More information about the webkit-reviews mailing list