[webkit-reviews] review granted: [Bug 228866] [ews] Ensure file handle is not leaked in loadConfig.py : [Attachment 435074] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 10:32:27 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 228866: [ews] Ensure file handle is not leaked in loadConfig.py
https://bugs.webkit.org/show_bug.cgi?id=228866

Attachment 435074: Patch

https://bugs.webkit.org/attachment.cgi?id=435074&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 435074
  --> https://bugs.webkit.org/attachment.cgi?id=435074
Patch

The change is clearly an improvement, but I'm curious if we actually observed
the problem in practice (i.e. observed that garbage collection didn't do it
quickly).


More information about the webkit-reviews mailing list