[webkit-reviews] review granted: [Bug 228724] Stop tracking form control elements in FormController : [Attachment 435036] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 228724: Stop tracking form control elements in FormController
https://bugs.webkit.org/show_bug.cgi?id=228724

Attachment 435036: Patch

https://bugs.webkit.org/attachment.cgi?id=435036&action=review




--- Comment #19 from Darin Adler <darin at apple.com> ---
Comment on attachment 435036
  --> https://bugs.webkit.org/attachment.cgi?id=435036
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435036&action=review

> Source/WebCore/html/FormController.cpp:382
> +    std::unique_ptr<SavedFormStateMap> stateMap =
createSavedFormStateMap(controls);

auto

> Source/WebCore/html/FormController.h:56
> -    typedef ListHashSet<RefPtr<HTMLFormControlElementWithState>>
FormElementListHashSet;
> +    typedef Vector<std::reference_wrapper<const
HTMLFormControlElementWithState>> FormControlVector;

Typically in new code we are using "using" instead of "typedef".