[webkit-reviews] review denied: [Bug 228748] Suspend WorkQueue of ResourceLoadStatistics and LocalStorage sooner : [Attachment 434933] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 228748: Suspend WorkQueue of ResourceLoadStatistics and LocalStorage sooner
https://bugs.webkit.org/show_bug.cgi?id=228748

Attachment 434933: Patch

https://bugs.webkit.org/attachment.cgi?id=434933&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 434933
  --> https://bugs.webkit.org/attachment.cgi?id=434933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434933&action=review

> Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:180
> +    m_queue->suspend([protectedThis = makeRef(*this)] {

This seems like a retain-cycle and will likely cause leaks. |this| refs m_queue
and m_queue refs |this| via m_suspendFunction.