[webkit-reviews] review granted: [Bug 228753] [iOS] getUserMedia sometimes doesn't capture from specified microphone : [Attachment 434997] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 228753: [iOS] getUserMedia sometimes doesn't capture from specified
microphone
https://bugs.webkit.org/show_bug.cgi?id=228753

Attachment 434997: Patch

https://bugs.webkit.org/attachment.cgi?id=434997&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 434997
  --> https://bugs.webkit.org/attachment.cgi?id=434997
Patch

We need to think of whether changing the default device should fire a
devicechange event.
As per spec, I would say yes, and it might make sense in MacOS. But let's leave
that to a follow-up

View in context: https://bugs.webkit.org/attachment.cgi?id=434997&action=review

> Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:122
> +    for (const auto& source : m_audioCaptureSources) {

Could we use anyOf maybe?