[webkit-reviews] review denied: [Bug 228710] [ARM64] Use link register instead of pinning a register for materializing big load constants : [Attachment 434993] Patch for reviewing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 09:21:15 PDT 2021


Saam Barati <sbarati at apple.com> has denied Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 228710: [ARM64] Use link register instead of pinning a register for
materializing big load constants
https://bugs.webkit.org/show_bug.cgi?id=228710

Attachment 434993: Patch for reviewing

https://bugs.webkit.org/attachment.cgi?id=434993&action=review




--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 434993
  --> https://bugs.webkit.org/attachment.cgi?id=434993
Patch for reviewing

Why are we pinning the data temp register? Isn’t the point of this patch to
stop doing that?


More information about the webkit-reviews mailing list