[webkit-reviews] review granted: [Bug 228805] [LFC][IFC] Add support for -webkit-nbsp-mode: space : [Attachment 434947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 5 05:20:11 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 228805: [LFC][IFC] Add support for -webkit-nbsp-mode: space
https://bugs.webkit.org/show_bug.cgi?id=228805

Attachment 434947: Patch

https://bugs.webkit.org/attachment.cgi?id=434947&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 434947
  --> https://bugs.webkit.org/attachment.cgi?id=434947
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434947&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:-54
> -    FlowHasWebKitNBSPMode			    = 1LLU  << 14,

maybe just leave a hole, like

// Unused			 = 1LLU << 14,

to avoid having to shift everything.


More information about the webkit-reviews mailing list