[webkit-reviews] review granted: [Bug 228802] REGRESSION (r280492): Clicking backspace on sign in fields results in deleting two characters instead of one : [Attachment 434942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 15:43:29 PDT 2021


Tim Horton <thorton at apple.com> has granted Dana Estra <destra at apple.com>'s
request for review:
Bug 228802: REGRESSION (r280492): Clicking backspace on sign in fields results
in deleting two characters instead of one
https://bugs.webkit.org/show_bug.cgi?id=228802

Attachment 434942: Patch

https://bugs.webkit.org/attachment.cgi?id=434942&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434942
  --> https://bugs.webkit.org/attachment.cgi?id=434942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434942&action=review

> Source/WebCore/ChangeLog:8
> +	   No tests yet.

The fact that this didn't break any tests is astounding; you should see if
Wenson has any good ideas about how to test the software keyboard codepath (we
may not have a good way, and no need for making one to block the regression
fix).


More information about the webkit-reviews mailing list