[webkit-reviews] review granted: [Bug 144456] TypeOfIsUndefined by-type folding should take advantage of the masquerades-as-undefined watchpoint : [Attachment 434939] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 144456: TypeOfIsUndefined by-type folding should take advantage of the
masquerades-as-undefined watchpoint
https://bugs.webkit.org/show_bug.cgi?id=144456

Attachment 434939: Patch

https://bugs.webkit.org/attachment.cgi?id=434939&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 434939
  --> https://bugs.webkit.org/attachment.cgi?id=434939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434939&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   TypeOfIsObject / TypeOfIsFunction by-type folding can't be improved
in the same way:
> +	   even if SpecObjectOther is a proven non-masquerader, we don't know
if it's callable.

Can you replace the FIXME's with comments to this effect?  This is an easy
detail to forget.  I would say something like - we could use the masquerade
watchpoint to prove it's not undefined, but we don't have a trick for
callability.