[webkit-reviews] review denied: [Bug 227951] [WPE] Implement fullscreen in WPEView : [Attachment 433792] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 4 13:10:26 PDT 2021

Adrian Perez <aperez at igalia.com> has denied  review:
Bug 227951: [WPE] Implement fullscreen in WPEView

Attachment 433792: Patch


--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 433792
  --> https://bugs.webkit.org/attachment.cgi?id=433792

View in context: https://bugs.webkit.org/attachment.cgi?id=433792&action=review

> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:260

It would be good to make guards check also WPE_CHECK_VERSION(1, 11, 1)
to make it possible to build WebKit using older libwpe versions.

> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:291
> +    wpe_view_backend_set_dom_fullscreen_client(m_backend,
&s_fullscreenClient, this);

You will need to adapt this to the function name changes in the version
of the libwpe PR that we got landed.

More information about the webkit-reviews mailing list